andygrove commented on code in PR #5634:
URL: https://github.com/apache/datafusion-comet/pull/5634#discussion_r4219359375
##########
dev/diffs/4.1.3.diff:
##########
@@ -423,7 +474,27 @@ index 0d807aeae4d..6d7744e771b 100644
}
test("A cached table preserves the partitioning and ordering of its cached
SparkPlan") {
-@@ -1673,9 +1674,18 @@ class CachedTableSuite extends QueryTest with
SQLTestUtils
+@@ -1595,7 +1602,8 @@ class CachedTableSuite extends QueryTest with
SQLTestUtils
+ }
+ }
+
+- test("SPARK-36120: Support cache/uncache table with TimestampNTZ type") {
++ test("SPARK-36120: Support cache/uncache table with TimestampNTZ type",
++ IgnoreComet("Comet's cache format reports Arrow buffer sizes")) {
+ val tableName = "ntzCache"
+ withTable(tableName) {
+ sql(s"CACHE TABLE $tableName AS SELECT TIMESTAMP_NTZ'2021-01-01
00:00:00'")
+@@ -1640,7 +1648,8 @@ class CachedTableSuite extends QueryTest with
SQLTestUtils
+ }
+ }
+
+- test("SPARK-35332: Make cache plan disable configs configurable - check
AQE") {
++ test("SPARK-35332: Make cache plan disable configs configurable - check
AQE",
++ IgnoreComet("Spark's SQL UI shows a cached plan only under Spark's own
cache scan")) {
Review Comment:
Good catch, thanks. Since #6577 the test finds the cached plan below
`CometInMemoryTableScanExec`, so 83ca07a7dd drops the `IgnoreComet` in the 4.0,
4.1 and 4.2 diffs.
It needed one more change to pass. The coalescing check, which the diffs
already adapt, looked for `AQEShuffleRead` only below a columnar-to-row
transition, which is where it is when Comet's plan is cached in Spark's format.
In Comet's columnar format the cached plan ends in the read itself, as in
Spark, so the check now accepts it there too. The patched test passes locally
on 4.0, 4.1 and 4.2 with either cache format, and with Comet off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
