comphead commented on code in PR #6651:
URL: https://github.com/apache/datafusion-comet/pull/6651#discussion_r4232154973
##########
spark/src/test/scala/org/apache/comet/CometJsonExpressionSuite.scala:
##########
@@ -185,6 +185,21 @@ class CometJsonExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelpe
}
}
+ test("from_json - duplicate struct field names fall back") {
Review Comment:
Could this move to a SQL file fixture? `structs_to_json.sql:20` shows the
pattern for the native opt-in, a file-level `-- Config:
spark.comet.expression.StructsToJson.allowIncompatible=true`. A new `from_json`
fixture with `-- Config:
spark.comet.expression.JsonToStructs.allowIncompatible=true` could hold both
queries as `query expect_fallback(unsupported output type)`, as
`create_map.sql:36` does, plus a unique-name `query` showing the native path
still runs. `json_to_structs.sql` cannot take it as is, because it has no
opt-in and never reaches the native path this PR changes. I have not run it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
