dwsmith1983 commented on code in PR #6712:
URL: https://github.com/apache/datafusion-comet/pull/6712#discussion_r4232684103
##########
spark/src/test/scala/org/apache/comet/CometCodegenSuite.scala:
##########
@@ -969,6 +1006,39 @@ class CometCodegenSuite
}
}
+ test("identical non-deterministic dispatched expressions keep their own
state") {
Review Comment:
> Could the fixture take over the cross-batch part with a `Config` line
setting `spark.comet.batchSize=2`, as `if_expr.sql` does, and this test be
dropped?
Done. The fixture now reads its 8 rows in four batches of 2, and the Scala
test is gone. A kernel rebuilt for every batch now fails it (rows 2 to 7 repeat
rows 0 and 1), which the fixture missed at the default batch size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
