jackylee-ch commented on code in PR #25694:
URL: https://github.com/apache/datafusion/pull/25694#discussion_r4271295874
##########
datafusion/functions-aggregate/src/count.rs:
##########
@@ -1204,4 +1205,45 @@ mod tests {
assert_eq!(merged.evaluate()?, ScalarValue::Int64(Some(3)));
Ok(())
}
+
+ #[test]
Review Comment:
Edit: superseded by d032a2283. Short column statistics now fail planning
with an error naming the provider, which also covers `COUNT(DISTINCT b)`
(rewritten into a `GROUP BY`), and the end-to-end test
`short_column_statistics_are_reported` checks that error for `count(b)` and a
plain scan. An earlier version of this reply said
`test_count_distinct_optimization` gained a short-statistics case; that was
wrong: the case passed without the guard and was never pushed. The `count` unit
test covers both branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
