patrickswedish commented on PR #26189: URL: https://github.com/apache/datafusion/pull/26189#issuecomment-6276552268
Hi @alamb! The reason CI doesn't catch this is that `ci/scripts/rust_clippy.sh` runs with a fixed feature set: ```bash CLIPPY_FEATURES="avro,integration-tests,extended_tests" cargo clippy --all-targets --workspace --features "$CLIPPY_FEATURES" -- -D warnings ``` However, DataFusion's contributor guide (`agent.md`) instructs developers to run: ```bash cargo clippy --all-targets --all-features -- -D warnings ``` When `--all-features` is enabled (as reported in #26181), features enabling nested Arrow array allocations on `ScalarValue` are pulled in, which transitively exposes `FixedSizeListArray` -> `TrackedReservation` -> `Mutex` / `UnsafeCell` inside `Expr`. Clippy traces this interior mutability chain and flags `HashSet<&Expr>` with `clippy::mutable_key_type`. This matches the existing allowances already in place across `expr_simplifier.rs`, `resolve_grouping_function.rs`, and `plan.rs` for `Expr` keys. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
