dwsmith1983 commented on PR #7127: URL: https://github.com/apache/datafusion-comet/pull/7127#issuecomment-6291390630
> Could we strip the password there too, or log `display_authority`-style output instead? Done in 65b5ad234. `object_store_authority` drops the ABFS password and keeps the container, so `url_key`, both debug lines, the cache key and the registration URL are password-free, and `deregister_store` names the store by its registry key. Credentials only come from configuration, so two URLs that differ only by password now share one store, which a test pins. The JVM side had the same leak: `AbfsAuthResolver` put the URI into messages that are forwarded to this native error and into a warning, and the mixed-store decline reason and `objectStoreKey` kept the raw authority. Those now use a password-free form as well, and `objectStoreKey` matches the native key again. > Could we sanitize at those two sites? A test that goes through `prepare_object_store_with_configs` would show whether the credentials actually stay out of the final error. Both are in. `object_store_backend` parses a copy without userinfo and query, and `normalize_object_store_url` names only the scheme. `prepare_errors_do_not_echo_userinfo_or_query` goes through `prepare_object_store_with_configs` with URLs rejected at each of the three points: the Azure builder, `ObjectStoreScheme::parse` and `Url::parse`. > Could you note on the issue which PR or test covers each item, so it can close cleanly with this PR? Done [on the issue](https://github.com/apache/datafusion-comet/issues/6605#issuecomment-6289487081). The S3 store's own messages are left to #7128, which I've narrowed to what remains. The title and description now cover the wider change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
