dwsmith1983 commented on issue #7128: URL: https://github.com/apache/datafusion-comet/issues/7128#issuecomment-6307618531
Two more sites, found in https://github.com/apache/datafusion-comet/pull/7127#pullrequestreview-5593859958, both in the Delta contrib: - `native/core/src/execution/planner/delta_spark_scan.rs:336`: `redacted_url_display` returns a URL without userinfo unchanged, and after masking userinfo it appends the query again, so a SAS token or signature survives either way. It could move next to the helpers in `url_redaction.rs` and drop the query. - `contrib/delta-spark/src/main/scala/org/apache/comet/contrib/delta/DeltaScanSupport.scala:574`: `objectStoreRejectedPathReason` prints `uri.toString` when there is no userinfo, which includes the query. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
