kosiew commented on code in PR #26040:
URL: https://github.com/apache/datafusion/pull/26040#discussion_r4346401030
##########
datafusion/functions-nested/src/array_filter.rs:
##########
@@ -52,7 +52,7 @@ make_higher_order_function_expr_and_func!(
#[user_doc(
doc_section(label = "Array Functions"),
- description = "filters the values of an array using a boolean lambda",
+ description = "filters the values of an array using a boolean lambda.
Lambda expressions require a dialect that supports them; set
`datafusion.sql_parser.dialect` to `DuckDB` because the default dialect does
not parse the `->` syntax.",
Review Comment:
Optional: consider adding `SET datafusion.sql_parser.dialect = 'DuckDB';`
before the SQL example, and similarly for the other three functions, so each
example is self-contained. The existing prose is already correct; if you adopt
this, please update the source examples and regenerate the reference.
##########
datafusion/functions-nested/src/array_transform.rs:
##########
@@ -49,7 +49,7 @@ make_higher_order_function_expr_and_func!(
#[user_doc(
doc_section(label = "Array Functions"),
- description = "transforms the values of an array",
+ description = "transforms the values of an array. Lambda expressions
require a dialect that supports them; set `datafusion.sql_parser.dialect` to
`DuckDB` because the default dialect does not parse the `->` syntax.",
Review Comment:
Optional follow-up: consider adding a DuckDB smoke test to the existing
array-transform SLT, verifying that `array_transform([1, 2, 3], x -> x * 2)`
returns `[2, 4, 6]`, then restoring the previous dialect. Existing Databricks
tests cover transformation behavior, so this would specifically validate the
recommended dialect configuration rather than address a missing correctness
test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
