kosiew commented on code in PR #26085:
URL: https://github.com/apache/datafusion/pull/26085#discussion_r4346990021
##########
datafusion/optimizer/src/extract_leaf_expressions.rs:
##########
Review Comment:
Could we update this test comment? It still describes an in-place extraction
and recovery projection, but the updated snapshot shows that the aggregate
blocks movement and the original projection remains unchanged.
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -4794,13 +4796,17 @@ mod tests {
.project(vec![leaf_udf_expr(col("a")), col("b")])?
.build()?;
- for plan in [simple, two_filters] {
+ // No filter: the extraction projection cannot move below the scan.
+ let no_filter = LogicalPlanBuilder::from(test_table_scan()?)
+ .project(vec![leaf_udf_expr(col("a"))])?
+ .build()?;
+
Review Comment:
Optional: Could we also include a leaf-expression projection over an
Aggregate in this fixed-point loop, using the grouped-struct shape from
`test_projection_with_leaf_expr_above_aggregate`? The existing snapshot covers
the aggregate barrier, but asserting an empty final pass here would
additionally verify convergence under the complete default optimizer sequence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
