alamb commented on code in PR #2660:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/2660#discussion_r4349931394


##########
tests/sqlparser_common.rs:
##########
@@ -21022,3 +21022,25 @@ fn parse_window_spec_keyword_base_window_name() {
         "SELECT count(*) OVER (ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT 
ROW) FROM t",
     );
 }
+

Review Comment:
   I bet if you changed these PRs so they didn't all try and put the tests at 
the end of this file (put it after different other tsts) they wouldn't all 
conflict



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to