comphead commented on code in PR #12227: URL: https://github.com/apache/datafusion/pull/12227#discussion_r1745751896
########## datafusion/functions/src/datetime/to_date.rs: ########## @@ -36,6 +39,13 @@ impl Default for ToDateFunc { } } +fn string_to_timestamp_millis_formatted(s: &str, format: &str) -> Result<i64> { Review Comment: can we have this method moved to `common.rs` where `string_to_timestamp_nanos_formatted` resides and ideally to have the same code format as nanos currently has -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org