snmvaughan commented on PR #7159: URL: https://github.com/apache/datafusion-comet/pull/7159#issuecomment-6367779480
Thanks @andygrove, @sunchao and @comphead. a5cbcd5 addresses the review: - `replace_with_spark_cast` checks `CastExpr::has_explicit_metadata()` instead of the target field's name, so an empty-named column keeps the read-conversion check. `is_schema_adaptation_cast` is gone. - `empty_named_column_long_read_as_int_errors`: an `INT64` column named `""` read as `int` raises `ParquetSchemaConvert` under both type-promotion settings. It fails on the previous head. - `schema_casts_are_told_apart_by_explicit_target` replaces the naming-convention test. - The substring tests are one table-driven test on `scan_parquet_file`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
