alamb commented on code in PR #26649:
URL: https://github.com/apache/datafusion/pull/26649#discussion_r4361260575
##########
xtask/src/ci_steps.rs:
##########
@@ -397,23 +397,32 @@ impl StepContext {
}
}
"extended" => {
+ // Run only the tests that the `workspace` step does not. The
+ // merge queue runs that step on the same commit.
command
.args([
"test",
"--profile",
"ci",
- "--exclude",
- "datafusion-examples",
- "--exclude",
- "datafusion-benchmarks",
- "--exclude",
- "datafusion-cli",
- "--workspace",
+ "-p",
+ "datafusion",
+ "-p",
+ "datafusion-physical-plan",
"--lib",
- "--tests",
- "--bins",
+ "--test",
+ "fuzz",
+ "--test",
+ "core_integration",
"--features",
-
"avro,json,backtrace,extended_tests,recursive_protection,parquet_encryption",
+ "avro,backtrace,extended_tests,parquet_encryption",
+ "--",
+ // Tests behind the `extended_tests` feature. A new
test
Review Comment:
this is a good idea
##########
xtask/src/ci_steps.rs:
##########
@@ -397,23 +397,32 @@ impl StepContext {
}
}
"extended" => {
+ // Run only the tests that the `workspace` step does not. The
+ // merge queue runs that step on the same commit.
command
.args([
"test",
"--profile",
"ci",
- "--exclude",
- "datafusion-examples",
- "--exclude",
- "datafusion-benchmarks",
- "--exclude",
- "datafusion-cli",
- "--workspace",
+ "-p",
+ "datafusion",
+ "-p",
+ "datafusion-physical-plan",
"--lib",
- "--tests",
- "--bins",
+ "--test",
+ "fuzz",
+ "--test",
+ "core_integration",
"--features",
-
"avro,json,backtrace,extended_tests,recursive_protection,parquet_encryption",
+ "avro,backtrace,extended_tests,parquet_encryption",
+ "--",
+ // Tests behind the `extended_tests` feature. A new
test
Review Comment:
But I worry about this list and the names of the tests getting out of sync.
Maybe as a follow on PR we could move all these "extended" tests into their
own binary rather than having to have a feature flag *and* a list here
```shell
cargo test --test core_integration_extended
```
Or something like that 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
