cj-zhukov commented on code in PR #26600: URL: https://github.com/apache/datafusion/pull/26600#discussion_r4362376043
########## datafusion-examples/examples/dataframe/main.rs: ########## @@ -21,12 +21,15 @@ //! //! ## Usage //! ```bash -//! cargo run --example dataframe -- [all|dataframe|deserialize_to_struct|cache_factory] +//! cargo run --example dataframe -- [all|aggregate|dataframe|deserialize_to_struct|cache_factory] //! ``` //! //! Each subcommand runs a corresponding example: //! - `all` — run all examples included in this module //! +//! - `aggregate` +//! (file: aggregate.rs, desc: Global and grouped aggregation with select and `aggregate`) Review Comment: I named it `aggregate` because the examples focus on aggregation, but I see your point that `select` better highlights the new API. I'll consider how to make the distinction between the two approaches clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
