ump45nose commented on PR #26662: URL: https://github.com/apache/datafusion/pull/26662#issuecomment-6407239437
Thanks for the review @jayzhan211, and for the repro. You're right, a saturated fetch just turns into an unbounded TopK. I switched to `checked_add` so the pushdown is skipped when the fetch would overflow, and added the `FOLLOWING`-start case to `window_limits.slt`. Pushed in 43debca. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
