LinSimon-901101 commented on PR #7155: URL: https://github.com/apache/datafusion-comet/pull/7155#issuecomment-6411455311
Thanks for the review, @andygrove . [[Fork CI](https://github.com/LinSimon-901101/datafusion-comet/actions/runs/40180323652)] passed on `c7ac767`. Regarding the design, keeping the assertion projection in Spark and feeding the native Iceberg writer through `CometSparkToColumnarExec` is a better direction. I’ll rework this PR around the suggestion. Once the changes are complete and full fork CI passes on the revised head, I’ll push the update to this PR. Meanwhile I'll add the `run-iceberg-tests` and `run-all-spark-profiles` labels so upstream CI includes that coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
