rich7420 commented on code in PR #6179:
URL: https://github.com/apache/datafusion-comet/pull/6179#discussion_r4404580448
##########
spark/src/main/scala/org/apache/comet/expressions/CometCast.scala:
##########
@@ -131,6 +131,10 @@ object CometCast
Compatible()
} else if (CometTimeZone.nativeId(cast.timeZoneId).isEmpty) {
CometTimeZone.supportLevel(cast.timeZoneId)
+ } else if (canProduceNullMapKey(cast)) {
Review Comment:
Keep numeric to BOOLEAN and TIMESTAMP to BIGINT map casts native. Neither
conversion can produce NULL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
