alamb commented on issue #22189: URL: https://github.com/apache/datafusion/issues/22189#issuecomment-6504244269
> Duplicate registration: each opened file gets two ParquetFileMetrics, one from the reader factory (DefaultParquetFileReaderFactory::create_reader) and one from ParquetMorselizer::prepare_open_file, plus a BaselineMetrics per file. That is about 40 filename-labelled metrics per file. Sharing a single instance per file would halve this without changing what users see, unless I'm missing a reason they're separate. reducing duplication also make s sense to me -- pklease create a single PR and tag me on it and I will be happy to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
