github-actions[bot] commented on PR #26842: URL: https://github.com/apache/datafusion/pull/26842#issuecomment-6463744523
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning 8f77b417a9b4fe0f143f50519db499b9de3f7a97 Building datafusion v55.1.0 (current) Built [ 47.394s] (current) Parsing datafusion v55.1.0 (current) Parsed [ 0.027s] (current) Building datafusion v55.1.0 (baseline) Built [ 13.024s] (baseline) Parsing datafusion v55.1.0 (baseline) Parsed [ 0.026s] (baseline) Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.458s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 62.741s] datafusion Building datafusion-common v55.1.0 (current) Built [ 12.786s] (current) Parsing datafusion-common v55.1.0 (current) Parsed [ 0.055s] (current) Building datafusion-common v55.1.0 (baseline) Built [ 0.933s] (baseline) Parsing datafusion-common v55.1.0 (baseline) Parsed [ 0.055s] (baseline) Checking datafusion-common v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.542s] 229 checks: 228 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/constructible_struct_adds_field.ron Failed in: field Column.id in /home/runner/work/datafusion/datafusion/datafusion/common/src/column.rs:111 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 15.509s] datafusion-common Building datafusion-expr v55.1.0 (current) Built [ 11.058s] (current) Parsing datafusion-expr v55.1.0 (current) Parsed [ 0.080s] (current) Building datafusion-expr v55.1.0 (baseline) Built [ 5.372s] (baseline) Parsing datafusion-expr v55.1.0 (baseline) Parsed [ 0.078s] (baseline) Checking datafusion-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 1.080s] 229 checks: 227 pass, 2 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/constructible_struct_adds_field.ron Failed in: field Alias.id in /home/runner/work/datafusion/datafusion/datafusion/expr/src/expr.rs:717 field Alias.kind in /home/runner/work/datafusion/datafusion/datafusion/expr/src/expr.rs:720 --- failure enum_struct_variant_field_added: pub enum struct variant field added --- Description: An enum's exhaustive struct variant has a new field, which has to be included when constructing or matching on this variant. ref: https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/enum_struct_variant_field_added.ron Failed in: field id of variant SavedName::Saved in /home/runner/work/datafusion/datafusion/datafusion/expr/src/expr_rewriter/mod.rs:359 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 18.740s] datafusion-expr Building datafusion-optimizer v55.1.0 (current) Built [ 12.211s] (current) Parsing datafusion-optimizer v55.1.0 (current) Parsed [ 0.027s] (current) Building datafusion-optimizer v55.1.0 (baseline) Built [ 5.442s] (baseline) Parsing datafusion-optimizer v55.1.0 (baseline) Parsed [ 0.027s] (baseline) Checking datafusion-optimizer v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.120s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 18.519s] datafusion-optimizer Building datafusion-proto v55.1.0 (current) Built [ 20.474s] (current) Parsing datafusion-proto v55.1.0 (current) Parsed [ 0.010s] (current) Building datafusion-proto v55.1.0 (baseline) Built [ 15.693s] (baseline) Parsing datafusion-proto v55.1.0 (baseline) Parsed [ 0.010s] (baseline) Checking datafusion-proto v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.107s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 37.426s] datafusion-proto Building datafusion-sql v55.1.0 (current) Built [ 9.492s] (current) Parsing datafusion-sql v55.1.0 (current) Parsed [ 0.025s] (current) Building datafusion-sql v55.1.0 (baseline) Built [ 8.845s] (baseline) Parsing datafusion-sql v55.1.0 (baseline) Parsed [ 0.026s] (baseline) Checking datafusion-sql v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.191s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 19.574s] datafusion-sql Building datafusion-substrait v55.1.0 (current) Built [ 192.430s] (current) Parsing datafusion-substrait v55.1.0 (current) Parsed [ 0.009s] (current) Building datafusion-substrait v55.1.0 (baseline) Built [ 12.908s] (baseline) Parsing datafusion-substrait v55.1.0 (baseline) Parsed [ 0.009s] (baseline) Checking datafusion-substrait v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.152s] 229 checks: 229 pass, 31 skip Summary no semver update required Finished [ 207.369s] datafusion-substrait ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
