github-actions[bot] commented on PR #26890: URL: https://github.com/apache/datafusion/pull/26890#issuecomment-6503797888
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning 14aa185dd23d83d100eff3e3824bffd60df15e41 Building datafusion-substrait v55.1.0 (current) Built [ 350.559s] (current) Parsing datafusion-substrait v55.1.0 (current) Parsed [ 0.013s] (current) Building datafusion-substrait v55.1.0 (baseline) Built [ 20.604s] (baseline) Parsing datafusion-substrait v55.1.0 (baseline) Parsed [ 0.013s] (baseline) Checking datafusion-substrait v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.231s] 229 checks: 225 pass, 4 fail, 0 warn, 31 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_substrait::logical_plan::consumer::from_scalar_function now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/expr/scalar_function.rs:17 datafusion_substrait::logical_plan::consumer::from_cast now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/expr/cast.rs:15 datafusion_substrait::logical_plan::consumer::from_cross_rel now takes 3 parameters instead of 2, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/rel/cross_rel.rs:12 datafusion_substrait::logical_plan::consumer::from_lambda now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/expr/lambda.rs:15 datafusion_substrait::logical_plan::consumer::from_filter_rel now takes 3 parameters instead of 2, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/rel/filter_rel.rs:12 datafusion_substrait::logical_plan::consumer::from_substrait_sorts now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/utils.rs:496 datafusion_substrait::logical_plan::consumer::from_field_reference now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/expr/field_reference.rs:14 datafusion_substrait::logical_plan::consumer::from_singular_or_list now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/expr/singular_or_list.rs:13 datafusion_substrait::logical_plan::consumer::from_exchange_rel now takes 3 parameters instead of 2, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/rel/exchange_rel.rs:13 datafusion_substrait::logical_plan::consumer::from_read_rel now takes 3 parameters instead of 2, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/rel/read_rel.rs:25 datafusion_substrait::logical_plan::consumer::from_project_rel now takes 3 parameters instead of 2, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/rel/project_rel.rs:19 datafusion_substrait::logical_plan::consumer::from_substrait_agg_func now takes 7 parameters instead of 6, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/expr/aggregate_function.rs:34 datafusion_substrait::logical_plan::consumer::from_substrait_rex now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/expr/mod.rs:47 datafusion_substrait::logical_plan::consumer::from_sort_rel now takes 3 parameters instead of 2, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/rel/sort_rel.rs:12 datafusion_substrait::logical_plan::consumer::from_join_rel now takes 3 parameters instead of 2, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/rel/join_rel.rs:18 datafusion_substrait::logical_plan::consumer::from_subquery now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/expr/subquery.rs:32 datafusion_substrait::logical_plan::consumer::from_fetch_rel now takes 3 parameters instead of 2, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/rel/fetch_rel.rs:12 datafusion_substrait::logical_plan::consumer::from_nested now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/expr/nested.rs:18 datafusion_substrait::logical_plan::consumer::from_substrait_rex_vec now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/expr/mod.rs:209 datafusion_substrait::logical_plan::consumer::from_substrait_rel now takes 3 parameters instead of 2, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/rel/mod.rs:40 datafusion_substrait::logical_plan::consumer::from_substrait_func_args now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/expr/function_arguments.rs:12 datafusion_substrait::logical_plan::consumer::from_set_rel now takes 3 parameters instead of 2, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/rel/set_rel.rs:17 datafusion_substrait::logical_plan::consumer::from_aggregate_rel now takes 3 parameters instead of 2, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/rel/aggregate_rel.rs:18 datafusion_substrait::logical_plan::consumer::from_if_then now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/expr/if_then.rs:10 datafusion_substrait::logical_plan::consumer::from_window_function now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/expr/window_function.rs:27 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/struct_missing.ron Failed in: struct datafusion_substrait::logical_plan::consumer::DefaultSubstraitLambdaConsumer, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks-shared/semver-checks/git-14aa185dd23d83d100eff3e3824bffd60df15e41/d57b449691f407ded7e260cd05d98392d1ac988c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:703 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/trait_method_missing.ron Failed in: method push_outer_schema of trait SubstraitConsumer, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks-shared/semver-checks/git-14aa185dd23d83d100eff3e3824bffd60df15e41/d57b449691f407ded7e260cd05d98392d1ac988c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:420 method pop_outer_schema of trait SubstraitConsumer, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks-shared/semver-checks/git-14aa185dd23d83d100eff3e3824bffd60df15e41/d57b449691f407ded7e260cd05d98392d1ac988c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:423 method get_outer_schema of trait SubstraitConsumer, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks-shared/semver-checks/git-14aa185dd23d83d100eff3e3824bffd60df15e41/d57b449691f407ded7e260cd05d98392d1ac988c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:430 method push_lambda_parameters of trait SubstraitConsumer, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks-shared/semver-checks/git-14aa185dd23d83d100eff3e3824bffd60df15e41/d57b449691f407ded7e260cd05d98392d1ac988c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:540 method pop_lambda_parameters of trait SubstraitConsumer, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks-shared/semver-checks/git-14aa185dd23d83d100eff3e3824bffd60df15e41/d57b449691f407ded7e260cd05d98392d1ac988c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:549 method lambda_variable of trait SubstraitConsumer, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks-shared/semver-checks/git-14aa185dd23d83d100eff3e3824bffd60df15e41/d57b449691f407ded7e260cd05d98392d1ac988c/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:555 --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/trait_method_parameter_count_changed.ron Failed in: SubstraitConsumer::consume_rel now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:183 SubstraitConsumer::consume_read now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:216 SubstraitConsumer::consume_filter now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:224 SubstraitConsumer::consume_fetch now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:232 SubstraitConsumer::consume_aggregate now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:240 SubstraitConsumer::consume_sort now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:248 SubstraitConsumer::consume_join now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:256 SubstraitConsumer::consume_project now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:264 SubstraitConsumer::consume_set now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:272 SubstraitConsumer::consume_cross now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:280 SubstraitConsumer::consume_consistent_partition_window now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:288 SubstraitConsumer::consume_exchange now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:296 SubstraitConsumer::consume_expression now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:311 SubstraitConsumer::consume_literal now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:320 SubstraitConsumer::consume_field_reference now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:328 SubstraitConsumer::consume_scalar_function now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:337 SubstraitConsumer::consume_window_function now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:346 SubstraitConsumer::consume_if_then now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:355 SubstraitConsumer::consume_switch now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:364 SubstraitConsumer::consume_singular_or_list now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:373 SubstraitConsumer::consume_multi_or_list now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:382 SubstraitConsumer::consume_cast now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:391 SubstraitConsumer::consume_subquery now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:400 SubstraitConsumer::consume_nested now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:409 SubstraitConsumer::consume_enum now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:418 SubstraitConsumer::consume_dynamic_parameter now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:427 SubstraitConsumer::consume_lambda now takes 3 instead of 2 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:448 SubstraitConsumer::consume_extension_leaf now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:462 SubstraitConsumer::consume_extension_single now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:476 SubstraitConsumer::consume_extension_multi now takes 2 instead of 1 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:490 Summary semver requires new major version: 4 major and 0 minor checks failed Finished [ 373.870s] datafusion-substrait ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
