haochunchang commented on code in PR #26202:
URL: https://github.com/apache/datafusion/pull/26202#discussion_r4423006292
##########
datafusion/sql/tests/cases/diagnostic.rs:
##########
@@ -791,3 +840,291 @@ fn test_window_function_alias_in_having() -> Result<()> {
assert_eq!(diag.span, Some(spans["a"]));
Ok(())
}
+
+#[test]
+fn test_duplicate_cte_name() -> Result<()> {
Review Comment:
For this specific test, the CTE error message (`diag.message`) is overlapped
with `cte.slt:29`.
This test mainly tests the span and the notes are correct.
The tests that need to be modified would be `test_duplicate_table_name()`
which can move some parts into slt tests.
The remaining tests assert Diagnostic spans/notes and planner warnings,
which aren't visible through slt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
