andygrove commented on PR #7311: URL: https://github.com/apache/datafusion-comet/pull/7311#issuecomment-6528455647
Thank you @sunchao, @comphead and @ErikBPF for the thorough reviews. Between you they found a stale-baseline diff, the hole in the schedule guard, a runner started on skipped runs, the case-insensitive branch and group comparisons, the same-commit collision, the over-wide bridge permissions and a wrong example of mine in the empty-diff case, and each one changed the code. This is now in the merge queue. Two things to watch after it lands. The `CI (fork)` bridge has only run against mocked APIs, so the first fork pull request after the merge is its real test, and the first scheduled nightly on `main` should still run. If either looks wrong, please say so here or on #7315. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
