devanbenz commented on PR #26249: URL: https://github.com/apache/datafusion/pull/26249#issuecomment-6529468821
@adriangb When you get a chance feel free to look again. Most of the new code additions should be tests, and test modifications due to the private API change for `HashTableLookupExpr`. Also, I am unable to run benchmarks would you mind triggering the `prepared_hash_join` and `hash_join_semi_anti` benches? Just to check regressions. There doesn't appear to be any benchmarks that measure partitioned joins (as far as I can tell). :thinking: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
