alamb commented on code in PR #26145:
URL: https://github.com/apache/datafusion/pull/26145#discussion_r4427464542
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -1263,6 +1545,601 @@ mod tests {
assert_eq!(meta, outer_ref.metadata(&schema).unwrap());
}
+ #[test]
Review Comment:
what cases does this cover that the .slt tests do not? Can we conslidate to
slt?
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -125,6 +128,215 @@ fn scalar_argument_for_field(expr: &Expr, arg_field:
&FieldRef) -> Option<Scalar
}
}
+// Resolve metadata bottom-up for branches whose metadata can be preserved.
Review Comment:
this seems quite complicated for resolving metadata -- can you explain why
it needs a custom worklist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
