zvonimir-dd commented on code in PR #2757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2757#discussion_r4429014061
##########
src/parser/mod.rs:
##########
@@ -15090,7 +15090,7 @@ impl<'a> Parser<'a> {
} else {
vec![]
};
- let limit = if self.parse_keyword(Keyword::LIMIT) {
+ let limit = if self.dialect.supports_delete_limit() &&
self.parse_keyword(Keyword::LIMIT) {
Review Comment:
`DELETE ... ORDER BY`, parsed a few lines above, is also MySQL/SQLite-only
but stays ungated, so `DELETE FROM t ORDER BY a` still parses in every dialect.
Same for `UPDATE ... LIMIT`. If we gate on dialect, it would be more consistent
to gate these together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
