dwsmith1983 commented on issue #6889: URL: https://github.com/apache/datafusion-comet/issues/6889#issuecomment-6545864701
I checked the credits in the draft post (apache/datafusion-site#210) against the authors of the PRs it links and the PRs merged for 1.2.0. - **Join output order**: the line thanks only `dwsmith1983`, but #6835 is yours and only #6810 is mine. Something like "thanks to `andygrove` and `dwsmith1983`" would fix it. - **Delta Lake (#5365)**: Scott Schenkein (`schenksj`) and Aditya Vaish (`adityavaish`) co-authored it and should be thanked with me. PRs the post links without a thanks: - More of the Plan Runs Natively: #6927 (`comphead`), #4727, #4715 and #4901 (`peterxcli`), #6180 and #6548 (`rich7420`), #6680 (`sam-1112`), #4974 (`0lai0`) and #6431 (`sunchao`) - In-memory cache: #6574 and #6577 (`comphead`) - Performance: #6969 (`Ersa-tech`), who is not mentioned anywhere else in the post - Upgrading: #6494 (`zhangfengcdt`) Contributors with PRs in 1.2.0 who are not mentioned at all. A few fit an existing section: - Performance: #5042 and #5322 (`kazantsev-maksim`), #6833 (`nat-openai`) - Iceberg: #6106 (`mixermt`), #7122 (`yunchipang`) The rest could go in a closing thanks list: #6831 (`nat-openai`), #7099 (`jadenfix`), #4971 (`u70b3`), #6651 (`Samearth17`), #6585 (`Smallfu666`), #6732 (`DeviousCardi`), #7004 (`arminazimi`), #6382 (`mizulun`), #6099 (`ErikBPF`) and #5876 (`athlcode`). The other thanks lines match the PR authors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
