sunchao commented on code in PR #6938:
URL: https://github.com/apache/datafusion-comet/pull/6938#discussion_r4433039846
##########
docs/source/user-guide/latest/operators.md:
##########
@@ -102,6 +101,7 @@ omitted from the tables below and may be reconsidered based
on demand:
| `ShuffledHashJoinExec` | ✅ |
|
| `SortMergeJoinExec` | ✅ | Supports `BINARY` join keys.
Nested-type (struct, array, map) and collated-string join keys fall back to
Spark. |
| `BroadcastNestedLoopJoinExec` | ✅ | Falls back to Spark when the
preserved side is broadcast (for example LEFT OUTER with BROADCAST on the left)
([#4429](https://github.com/apache/datafusion-comet/pull/4429)). |
+| `CartesianProductExec` | ✅ | Opt-in
(`spark.comet.exec.cartesianProduct.enabled`). Only condition-free products of
single-partition inputs, such as after `COALESCE(1)`; never a bare file scan.
|
Review Comment:
Could this say that ordinary **non-bucketed** file scans do not qualify? The
gate checks each child’s reported partition count.
`CometNativeScanExec.outputPartitioning` delegates to Spark for a bucketed
scan, so a one-bucket scan can report one partition without an intervening
`COALESCE(1)`. The same wording appears in the config note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
