SingletonYe commented on PR #26657: URL: https://github.com/apache/datafusion/pull/26657#issuecomment-6547826614
Thanks — moved it to the rule that leaves the name. `rewrite_set_comparison` now wraps `map_expressions` in a `NamePreserver`, the same way `simplify_exprs` and `type_coercion` do, so the `CASE WHEN EXISTS …` never carries a stale name out of the rule. I removed the `decorrelate_predicate_subquery.rs` change entirely: that file is back to `main`'s version and is no longer part of the diff. Two files now instead of three. Added your qualified-column case as a fourth `subquery.slt` test. Verified on the branch: `subquery.slt` (all four cases), `subquery_projection.slt`, `subquery_sort.slt`, `merge_into.slt` and `null_aware_mark_join.slt` pass, and `cargo test -p datafusion-optimizer` is 951 + 29 + 5 passed, 0 failed. That is `ed26e85`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
