samuel7james opened a new pull request, #2787: URL: https://github.com/apache/datafusion-ballista/pull/2787
# Which issue does this PR close? Closes #2766. # Rationale for this change When the scheduler can't write to `event_log_dir`, the event-log writer logs a warning on its own task and stops, so the scheduler runs with no event logs. # What changes are included in this PR? - `ballista_history::writer::check_log_dir` creates the directory if needed, then creates and removes a file in it. - `SchedulerServer::init` calls it when `event_log_dir` is set and returns a `Configuration` error naming the directory, so the scheduler fails to start. Embedders that call `init` (such as Comet) get the same check. - Tests: `check_log_dir` on a new nested directory and on a path under a regular file, and `init_fails_when_event_log_dir_is_not_writable`, which fails without the change. The scheduler lib tests pass, and clippy and rustfmt are clean. # Are there any user-facing changes? The scheduler now exits at startup, instead of running without event logs, when `--event-log-dir` can't be written. The history server guide says so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
