dwsmith1983 opened a new issue, #7559:
URL: https://github.com/apache/datafusion-comet/issues/7559
### Describe the bug
Found while working on #7128. Several native Iceberg errors print a data or
delete file path exactly as the catalog recorded it:
- `iceberg_location_scoped.rs`: "Invalid S3 path {path}", "S3 path {path}
has no bucket"
- `iceberg_scan.rs`: "Failed to stat delete file '{path}'" and the size
check after it
- `iceberg_write.rs`: "{path} is not the data file this output was made
for", "... on the output of data file {path}"
- `planner.rs`: "Delete file '{file_path}' has a negative {what}"
A location with a password in its userinfo or a SAS token or signature in
its query string would end up in task failures and logs. Catalog locations
rarely carry credentials, so this is low risk, but it is the same leak #7128
fixes for Parquet, Delta and object store paths.
### Steps to reproduce
Each message formats the path with `{path}` as is, so a location like
`s3://alice:SECRET@bucket/t/delete.parquet?sig=TOKEN` reaching any of them is
printed with `SECRET` and `TOKEN`.
### Expected behavior
These messages show the path without its password, username or query, using
the URL redaction helpers #7127 adds, as the #7128 pull requests do for the
other paths.
### Additional context
Not part of the four #7128 pull requests, which cover object store setup,
the Parquet writer, native Delta and the JVM rejected path reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
