alamb commented on code in PR #27159: URL: https://github.com/apache/datafusion/pull/27159#discussion_r4512223909
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -759,6 +759,14 @@ SELECT approx_median(c12) FROM aggregate_test_100 statement error SELECT approx_median(c1) FROM aggregate_test_100 +# APPROX_MEDIAN ignores aggregate ORDER BY keys. They must not be interpreted Review Comment: > APPROX_MEDIAN would keep the percentile fixed at 0.5 and process x in the requested order. Does this approach make sense to you? yes I am not sure how important this is to be honest. I think I need to spend my time on more impactful things -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
