ump45nose commented on PR #2816: URL: https://github.com/apache/datafusion-ballista/pull/2816#issuecomment-6734710712
Thanks @andygrove — addressed the review notes: - `python/Cargo.lock` now includes `socket2` on `ballista-scheduler` (`cargo update -p ballista-scheduler`). - `features = ["all"]` moved to a `[dev-dependencies]` `socket2` entry; the main dependency no longer enables it. - Gated `configures_nodelay_and_keepalive_on_accepted_connections` with `#[cfg(not(windows))]` because `tcp_keepalive_time()` is unavailable there in socket2 0.6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
