vinycalves commented on code in PR #27278: URL: https://github.com/apache/datafusion/pull/27278#discussion_r4525757538
########## datafusion/physical-plan/src/joins/sort_merge_join/tests.rs: ########## Review Comment: The test's 600-row groups are split into 250-row batches, but the pairing threshold is 256. Does any test actually hit the filtered pairing path, including its spilled-batch branch? ########## datafusion/physical-plan/src/joins/sort_merge_join/tests.rs: ########## Review Comment: The tests compare sorted results and only assert key order. Does anything verify exact row order within a key? ########## datafusion/physical-plan/src/joins/sort_merge_join/materializing_stream.rs: ########## Review Comment: Why does the pairing path use only a fixed 256-row threshold while the freeze path uses a cost model? Could high-pass wide joins regress? ########## datafusion/physical-plan/src/joins/sort_merge_join/materializing_stream.rs: ########## Review Comment: What happens if the join filter is volatile or stateful? Early evaluation changes when and how often it runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
