NoahKusaba opened a new pull request, #2835:
URL: https://github.com/apache/datafusion-ballista/pull/2835
# Which issue does this PR close?
No issue filed; small fix.
# Rationale for this change
#1705 added `if test -z "${CI}"` to both Docker build scripts to skip the
cli and benchmarks images in CI. Both scripts run under `set -u`, so on any
machine without `CI` set they abort before building an image:
```
./dev/build-ballista-executables.sh: line 43: CI: unbound variable
```
This breaks `dev/integration-tests.sh` and the documented local Docker
build. CI never hits it because GitHub Actions sets `CI=true`.
# What changes are included in this PR?
`${CI}` → `${CI:-}` in `dev/build-ballista-executables.sh` and
`dev/build-ballista-docker.sh`. CI behaviour is unchanged. Locally, the scripts
build all images again, including the benchmarks image that
`docker-compose.yml` uses.
# Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
