EmilyMatt commented on code in PR #27302:
URL: https://github.com/apache/datafusion/pull/27302#discussion_r4535333628
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -93,6 +123,24 @@ impl BinaryExpr {
op: self.op,
right: self.right,
fail_on_overflow,
+ // Same children, so the volatility is unchanged
+ children_volatility: self.children_volatility,
+ }
+ }
+
+ /// Whether the left child (or anything under it) is volatile
+ fn left_is_volatile(&self) -> bool {
+ match self.children_volatility {
+ Some(v) => v.left,
+ None => subtree_is_volatile(&self.left),
+ }
+ }
+
+ /// Whether the right child (or anything under it) is volatile
+ fn right_is_volatile(&self) -> bool {
Review Comment:
likewise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
