Nagato-Yuzuru opened a new pull request, #27326:
URL: https://github.com/apache/datafusion/pull/27326
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Part of #27082.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
Please explain the problem you are trying to solve in terms of the
user-visible
behavior, rather than the implementation.
For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the
implementation. "COUNT(DISTINCT) returns wrong results when the column
contains
nulls" is the user-visible problem.
-->
The `EquivalenceProperties` fuzz tests use their own seed loops. This PR
moves them to the shared `FuzzTest` driver.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here, but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Move `core/tests/fuzz_cases/equivalence/` to
`fuzz/tests/suites/equivalence/`.
- Each random test is now a check function `fn(seed, null_pct)`. One `(seed,
null_pct)` iteration of the old loop is now one case. Case seed `k` selects
table seed `k / 3` and `NULL_PCTS[k % 3]`, which is the same order as the old
`cartesian_product`.
- `EquivalenceFuzzer` and the `FUZZERS` table register the 7 suites. The
suite names are the old test names.
- The deterministic tests in `ordering.rs` move with `utils.rs` and stay
plain `#[test]`s.
The test logic does not change.
## What is the testing strategy for this PR?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
Briefly describe how this PR is tested, and point to the specific tests you
added. For example: 'This new feature is covered by the `sqllogictest` cases
added in `foo.slt`'.
If this PR does not add tests, explain why. For example, if the change is
already covered by existing tests, please mention it.
You should also check the `codecov` bot reply on this PR to confirm the
changed code is exercised.
-->
- The suites run the same 3 x N inputs as before (15/300/300/60/60/300/300
cases).
- I reverted the fix from #24276 locally.
`test_ordering_satisfy_with_equivalence_complex_random` failed at case seed 49
(seed 16, null_pct 0.1).
On CI time, the driver runs suites one after another. So the `fuzz` step
takes about 50s more. The total CPU time does not change (about 53s now, about
56s before).
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
