Rich-T-kid commented on PR #26789: URL: https://github.com/apache/datafusion/pull/26789#issuecomment-6863478910
The c37a2aada same-SHA rerun passes the TPC-H timing gate with RLE dictionary reads disabled: - Q1: 42.22 -> 39.85 ms minimum (-5.61%); 43.09 -> 40.81 ms mean (-5.29%) - Q19: 32.08 -> 29.91 ms minimum (-6.76%); 32.58 -> 30.97 ms mean (-4.94%) - Q16 is now byte-identical with the optimizer disabled. Its residual +0.51% minimum / +0.65% mean movement is run noise rather than the removed rewrite. The bot reports 2 faster, 0 slower, 20 unchanged, and 0 failures. Total minimum time improves 722.40 -> 720.50 ms (-0.26%); total mean improves 737.70 -> 734.64 ms (-0.41%). The column search is exhaustive for this workload: 29 TPC-H string columns accounted for, all 23 read by Q1-Q22 tested across 52 query/column pairs. The last plausible Q19 compound was also rejected: adding p_brand or p_container to l_shipinstruct+l_shipmode regressed about 0.97% each, and adding both was unstable with essentially no pooled-median gain. Memory caveat: Q1 again increases its MemoryPool peak from 30.0 to 40.1 MiB (+10.1 MiB), although the suite maximum remains 167.1 MiB, peak RSS falls from 1.2 to 1.1 GiB, average RSS falls from 494.3 to 485.2 MiB, and neither side spills. The PR remains draft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
