kumarUjjawal commented on PR #25740:
URL: https://github.com/apache/datafusion/pull/25740#issuecomment-6890217372

   Please delete `aggregate_order_by.slt`. It is not related to `map_agg` and 
it is still in the branch. Next, both accumulators must handle NULL keys the 
same way. Please reject them in `update_batch` with one message, `map key 
cannot be null`. Then update the SLT test and the module docs that still say 
the pair is dropped. The reverse logic is also wrong when the input is not 
pre-sorted. The simplest fix is to sort by the `ORDER BY` as given and reverse 
only on output, like `array_agg` does. You can also return `NotSupported` from 
`reverse_expr` for now. `DISTINCT` is ignored right now, so please document it 
with a test, or reject it. The two accumulators also repeat the same decode and 
map-build code. Please make them share `map_row_to_scalars` and 
`build_single_map`, and move those helpers into `map_agg.rs`. In the docs, 
please say that the result order without `ORDER BY` is not guaranteed. Also say 
that NULL keys fail and that empty input returns `NULL`. Last, please add tests 
f
 or multi-partition reversed input, window use, and nested values.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to