shrivasshankar commented on code in PR #27148:
URL: https://github.com/apache/datafusion/pull/27148#discussion_r4580922543
##########
datafusion/physical-expr/src/analysis.rs:
##########
@@ -148,6 +149,9 @@ impl ExprBoundaries {
/// # Returns
///
/// * `AnalysisContext` constructed by pruned boundaries and a selectivity
value.
+/// The selectivity is `None` when the number of values of a column in `expr`
Review Comment:
Thanks for the review and for running the benchmarks! Added your test (it
fails without the `!into.is_decimal()` check, on the `(Decimal128(19, 0),
Int64)` case), and a note about `analyze` under user-facing changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]