morristai commented on code in PR #26634:
URL: https://github.com/apache/datafusion/pull/26634#discussion_r4584349993
##########
datafusion/physical-optimizer/src/projection_pushdown.rs:
##########
@@ -433,6 +465,29 @@ impl<'a> JoinFilterRewriter<'a> {
}
}
+/// Returns the number of leading children of `expr` that are evaluated for
every row, or `None`
+/// if all children are. The remaining children may be skipped for some rows.
+///
+/// Mirrors `conditional_children` in the logical `CommonSubexprEliminate`
rule.
+fn always_evaluated_child_count(expr: &dyn PhysicalExpr) -> Option<usize> {
Review Comment:
Done. I added `PhysicalExpr::short_circuits`, which returns `false` by
default, and removed the list. (`FFI_PhysicalExpr` does not forward this method
yet, because that needs a struct layout change.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]