HuSen8891 commented on code in PR #12467:
URL: https://github.com/apache/datafusion/pull/12467#discussion_r1764436517
##########
datafusion/sql/src/expr/identifier.rs:
##########
@@ -186,7 +186,22 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let s = &ids[0..ids.len()];
// safe unwrap as s can never be empty or exceed
the bounds
let (relation, column_name) =
form_identifier(s).unwrap();
- Ok(Expr::Column(Column::new(relation,
column_name)))
+ // sanity check on column
Review Comment:
That‘s good idea.
Add method 'check_ambiguous_name' to check ambiguous column reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
