dwsmith1983 commented on PR #7130: URL: https://github.com/apache/datafusion-comet/pull/7130#issuecomment-6951725255
> Could you add a `TIMESTAMP` child next to `x` in "nested struct field renamed by case only"? Added in 807ed106d. `s` is now `STRUCT<x: INT, ts: TIMESTAMP, y: INT>` with different sub-second timestamps in the two rows, and the test reads `ts` through the whole struct, on its own, beside `s.X`, and under the `s.X = 20` filter. It passes on 3.5, 4.0 and 4.1. Main is merged into the branch as well. I couldn't run it against an iceberg-rust from before apache/iceberg-rust#3255. Every earlier commit predates the HDFS storage Comet now builds with, and reverting #3255 on the current pin conflicts in `record_batch_transformer.rs` and `reader/projection.rs`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
