bvolpato commented on code in PR #26839:
URL: https://github.com/apache/datafusion/pull/26839#discussion_r4602006968
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/clustered.rs:
##########
@@ -394,7 +406,10 @@ mod tests {
key_types.push(DataType::Timestamp(unit,
timezone.map(Into::into)));
}
}
- for key_type in key_types {
+ for (key_type_index, key_type) in key_types.into_iter().enumerate() {
Review Comment:
Applied in 09ee0fff. The loop now uses
`skip(shard).step_by(KEY_TYPE_SHARD_COUNT)`. All eight sorted and unsorted
matrix cases passed locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]