LiaCastaneda commented on code in PR #27099:
URL: https://github.com/apache/datafusion/pull/27099#discussion_r4610921390


##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -2755,6 +2755,466 @@ async fn 
roundtrip_lambda_parameter_struct_field_names() -> Result<()> {
     Ok(())
 }
 
+// Substrait literals carry no struct field names, so a struct literal 
combined with a
+// struct column must take the column's field names for the two to have the 
same type.
+
+/// A context with a table `structs` whose column `s` is a list of structs.
+async fn struct_lists_ctx() -> Result<SessionContext> {

Review Comment:
   inlined it inside `assert_struct_literal_roundtrips`, it now creates the two 
table every test uses



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to