palaska commented on code in PR #1057:
URL:
https://github.com/apache/datafusion-ballista/pull/1057#discussion_r1765529411
##########
ballista/core/build.rs:
##########
@@ -37,10 +37,13 @@ fn main() -> Result<(), String> {
// We don't include the proto files in releases so that downstreams
// do not need to have PROTOC included
if Path::new("proto/datafusion.proto").exists() {
+ println!("cargo:rerun-if-changed=proto/datafusion_common.proto");
println!("cargo:rerun-if-changed=proto/datafusion.proto");
println!("cargo:rerun-if-changed=proto/ballista.proto");
tonic_build::configure()
+ .extern_path(".datafusion_common", "::datafusion_proto_common")
.extern_path(".datafusion", "::datafusion_proto::protobuf")
+ .protoc_arg("--experimental_allow_proto3_optional")
Review Comment:
this is the flag, same seems to be used in Datafusion as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
