andygrove commented on code in PR #2749:
URL: 
https://github.com/apache/datafusion-ballista/pull/2749#discussion_r4643003923


##########
ballista/core/src/execution_plans/runtime_filter.rs:
##########
@@ -481,6 +512,12 @@ impl ExecutionPlan for RuntimeFilterApplyExec {
         let Some(filter) = self.filter.clone() else {
             return Ok(input);
         };
+        // Preserve the payload's bounds for scan pruning, but avoid hashing

Review Comment:
   Small one. The comment here says the bounds are kept for scan pruning, but I 
don't think anything reads them yet. Could we reword it until Task 3 lands? 
Also, since `prepare` already has the merged filter, would it be simpler to 
make the near-saturation decision there once? Then a bypassed filter doesn't 
ship its payload to every task or recount the bits per partition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to