andygrove commented on PR #27530:
URL: https://github.com/apache/datafusion/pull/27530#issuecomment-7042292244

   Thanks for running these. I looked into the queries flagged as slower:
   
   - ClickBench has no joins, so the 5% to 27% swings both ways there are noise.
   - TPC-H Q14 and Q19 are flagged in only one of the two tables.
   - Of the TPC-DS queries flagged slower (Q20, Q21, Q22, Q40, Q73), only Q40 
groups any map (1 of its 4). The others never reach the grouping code. For them 
the PR only adds a counter on insert and an early return before grouping.
   
   I ran an A/B of the same two commits (477c7b9 and 104d556) with 
`datafusion-cli` on an AMD 7950X3D. It took 20 warm runs per query, over three 
rounds alternating between builds. Every flagged query is within 1 ms of `main`:
   
   | Query | Maps grouped | main (min / median) | this PR (min / median) |
   | ----- | ------------ | ------------------- | ---------------------- |
   | TPC-DS Q20 | 0 | 11 / 12 ms | 11 / 12–13 ms |
   | TPC-DS Q21 | 0 | 14–15 / 15 ms | 14–15 / 15 ms |
   | TPC-DS Q22 | 0 | 304–311 / 314–316 ms | 307–310 / 312–314 ms |
   | TPC-DS Q40 | 1 of 4 | 95–96 / 97–100 ms | 95 / 98–99 ms |
   | TPC-DS Q73 | 0 | 5 / 5 ms | 5 / 5 ms |
   | TPC-H Q14 | 0 | 27–28 / 28–29 ms | 27 / 29 ms |
   | TPC-H Q19 | 0 | 37 / 38–39 ms | 36–37 / 38–39 ms |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to