mbutrovich commented on code in PR #962:
URL: https://github.com/apache/datafusion-comet/pull/962#discussion_r1774297891
##########
native/core/src/execution/datafusion/planner.rs:
##########
@@ -917,15 +917,11 @@ impl PhysicalPlanner {
let fetch = sort.fetch.map(|num| num as usize);
- let copy_exec = if can_reuse_input_batch(&child) {
- Arc::new(CopyExec::new(child, CopyMode::UnpackOrDeepCopy))
- } else {
- Arc::new(CopyExec::new(child, CopyMode::UnpackOrClone))
- };
+ let child = Self::wrap_in_copy_exec(child);
Review Comment:
Can you add a similar comment here as you added with HashJoin on why Sort
needs a CopyExec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
