findepi commented on code in PR #13388:
URL: https://github.com/apache/datafusion/pull/13388#discussion_r1840097236
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -392,14 +392,6 @@ pub fn create_hashes<'a>(
let array: &FixedSizeBinaryArray =
array.as_any().downcast_ref().unwrap();
hash_array(array, random_state, hashes_buffer, rehash)
}
- DataType::Decimal128(_, _) => {
Review Comment:
quoting commit message from the first commit
https://github.com/apache/datafusion/pull/13388/commits/1e6994688b8c3eb814336ebe21e43dea79960b30
```
Remove unused code paths from create_hashes
The `downcast_primitive_array!` macro handles all primitive types
and only then delegates to fallbacks. It handles Decimal128 and
Decimal256 internally.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
