comphead commented on code in PR #14056:
URL: https://github.com/apache/datafusion/pull/14056#discussion_r1909144536
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -440,13 +440,13 @@ fn get_valid_types(
fn function_length_check(length: usize, expected_length: usize) ->
Result<()> {
if length < 1 {
Review Comment:
wondering if this check really needed? would be that enough just to compare
with expected_length?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
